qjyu
/
OrangePi_CM5
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
OrangePi_CM5/drivers/gpu/drm/gma500
History
Hans de Goede c5812807e4 drm/gma500: Fix BUG: sleeping function called from invalid context errors 
[ Upstream commit 63e37a79f7bd939314997e29c2f5a9f0ef184281 ]

gma_crtc_page_flip() was holding the event_lock spinlock while calling
crtc_funcs->mode_set_base() which takes ww_mutex.

The only reason to hold event_lock is to clear gma_crtc->page_flip_event
on mode_set_base() errors.

Instead unlock it after setting gma_crtc->page_flip_event and on
errors re-take the lock and clear gma_crtc->page_flip_event it
it is still set.

This fixes the following WARN/stacktrace:

[  512.122953] BUG: sleeping function called from invalid context at kernel/locking/mutex.c:870
[  512.123004] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 1253, name: gnome-shell
[  512.123031] preempt_count: 1, expected: 0
[  512.123048] RCU nest depth: 0, expected: 0
[  512.123066] INFO: lockdep is turned off.
[  512.123080] irq event stamp: 0
[  512.123094] hardirqs last  enabled at (0): [<0000000000000000>] 0x0
[  512.123134] hardirqs last disabled at (0): [<ffffffff8d0ec28c>] copy_process+0x9fc/0x1de0
[  512.123176] softirqs last  enabled at (0): [<ffffffff8d0ec28c>] copy_process+0x9fc/0x1de0
[  512.123207] softirqs last disabled at (0): [<0000000000000000>] 0x0
[  512.123233] Preemption disabled at:
[  512.123241] [<0000000000000000>] 0x0
[  512.123275] CPU: 3 PID: 1253 Comm: gnome-shell Tainted: G        W         5.19.0+ #1
[  512.123304] Hardware name: Packard Bell dot s/SJE01_CT, BIOS V1.10 07/23/2013
[  512.123323] Call Trace:
[  512.123346]  <TASK>
[  512.123370]  dump_stack_lvl+0x5b/0x77
[  512.123412]  __might_resched.cold+0xff/0x13a
[  512.123458]  ww_mutex_lock+0x1e/0xa0
[  512.123495]  psb_gem_pin+0x2c/0x150 [gma500_gfx]
[  512.123601]  gma_pipe_set_base+0x76/0x240 [gma500_gfx]
[  512.123708]  gma_crtc_page_flip+0x95/0x130 [gma500_gfx]
[  512.123808]  drm_mode_page_flip_ioctl+0x57d/0x5d0
[  512.123897]  ? drm_mode_cursor2_ioctl+0x10/0x10
[  512.123936]  drm_ioctl_kernel+0xa1/0x150
[  512.123984]  drm_ioctl+0x21f/0x420
[  512.124025]  ? drm_mode_cursor2_ioctl+0x10/0x10
[  512.124070]  ? rcu_read_lock_bh_held+0xb/0x60
[  512.124104]  ? lock_release+0x1ef/0x2d0
[  512.124161]  __x64_sys_ioctl+0x8d/0xd0
[  512.124203]  do_syscall_64+0x58/0x80
[  512.124239]  ? do_syscall_64+0x67/0x80
[  512.124267]  ? trace_hardirqs_on_prepare+0x55/0xe0
[  512.124300]  ? do_syscall_64+0x67/0x80
[  512.124340]  ? rcu_read_lock_sched_held+0x10/0x80
[  512.124377]  entry_SYSCALL_64_after_hwframe+0x63/0xcd
[  512.124411] RIP: 0033:0x7fcc4a70740f
[  512.124442] Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89 44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <89> c2 3d 00 f0 ff ff 77 18 48 8b 44 24 18 64 48 2b 04 25 28 00 00
[  512.124470] RSP: 002b:00007ffda73f5390 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
[  512.124503] RAX: ffffffffffffffda RBX: 000055cc9e474500 RCX: 00007fcc4a70740f
[  512.124524] RDX: 00007ffda73f5420 RSI: 00000000c01864b0 RDI: 0000000000000009
[  512.124544] RBP: 00007ffda73f5420 R08: 000055cc9c0b0cb0 R09: 0000000000000034
[  512.124564] R10: 0000000000000000 R11: 0000000000000246 R12: 00000000c01864b0
[  512.124584] R13: 0000000000000009 R14: 000055cc9df484d0 R15: 000055cc9af5d0c0
[  512.124647]  </TASK>

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220906203852.527663-2-hdegoede@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
 		2022-09-28 11:10:39 +02:00
..
Kconfig
…
Makefile
…
accel_2d.c drm/gma500: fix null dereference of pointer fb before null check 2019-12-19 15:33:40 +01:00
backlight.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 335 2019-06-05 17:37:06 +02:00
blitter.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288 2019-06-05 17:36:37 +02:00
blitter.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
cdv_device.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
cdv_device.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
cdv_intel_crt.c drm/gma500: Use simple encoder 2020-04-02 14:16:44 +02:00
cdv_intel_display.c drm/gma500: Convert to CRTC VBLANK callbacks 2020-02-13 13:08:13 +01:00
cdv_intel_dp.c drm/gma500: fix double free of gma_connector 2020-12-30 11:52:55 +01:00
cdv_intel_hdmi.c drm/gma500: Use simple encoder 2020-04-02 14:16:44 +02:00
cdv_intel_lvds.c drm/gma500: Remove dead code 2020-04-21 09:02:29 +02:00
framebuffer.c drm/gma500: Add the missed drm_gem_object_put() in psb_user_framebuffer_create() 2021-07-20 16:05:48 +02:00
framebuffer.h drm/gma500: Remove struct psb_fbdev 2019-11-25 11:19:31 +01:00
gem.c drm/gma500: remove _unlocked suffix in drm_gem_object_put_unlocked 2020-05-19 22:31:32 +01:00
gem.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288 2019-06-05 17:36:37 +02:00
gma_device.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
gma_device.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
gma_display.c drm/gma500: Fix BUG: sleeping function called from invalid context errors 2022-09-28 11:10:39 +02:00
gma_display.h drm/gma500: Add page flip support on psb/cdv 2019-11-07 10:16:31 +01:00
gtt.c remove ioremap_nocache and devm_ioremap_nocache 2020-01-06 09:45:59 +01:00
gtt.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
intel_bios.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
intel_bios.h drm/gma500/intel_bios.h: Replace zero-length array with flexible-array member 2020-03-06 11:40:53 +01:00
intel_gmbus.c drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
intel_i2c.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
mdfld_device.c drm: gma500: Convert to GPIO descriptors 2020-08-19 15:48:09 +02:00
mdfld_dsi_dpi.c drm: gma500: Convert to GPIO descriptors 2020-08-19 15:48:09 +02:00
mdfld_dsi_dpi.h
…
mdfld_dsi_output.c drm: gma500: Convert to GPIO descriptors 2020-08-19 15:48:09 +02:00
mdfld_dsi_output.h drm: gma500: Convert to GPIO descriptors 2020-08-19 15:48:09 +02:00
mdfld_dsi_pkg_sender.c drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
mdfld_dsi_pkg_sender.h
…
mdfld_intel_display.c drm/gma500: Remove dead code 2020-04-21 09:02:29 +02:00
mdfld_output.c
…
mdfld_output.h drm: gma500: Convert to GPIO descriptors 2020-08-19 15:48:09 +02:00
mdfld_tmd_vid.c drm/gma500: Use simple encoder 2020-04-02 14:16:44 +02:00
mdfld_tpo_vid.c drm/gma500: Use simple encoder 2020-04-02 14:16:44 +02:00
mid_bios.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
mid_bios.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
mmu.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
mmu.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288 2019-06-05 17:36:37 +02:00
oaktrail.h Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
oaktrail_crtc.c drm/gma500: fix memory disclosures due to uninitialized bytes 2019-10-22 10:59:36 +02:00
oaktrail_device.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
oaktrail_hdmi.c drm/gma500: remove unused variable 'hdmi_ids' 2020-04-21 08:15:03 +02:00
oaktrail_hdmi_i2c.c gma500: clean up error handling in init 2021-03-04 11:37:36 +01:00
oaktrail_lvds.c drm/gma500: Fix end of loop tests for list_for_each_entry 2021-09-15 09:50:31 +02:00
oaktrail_lvds_i2c.c drm/gma500: drop drmp.h include from all .c files 2019-05-22 14:13:40 +02:00
opregion.c
…
opregion.h
…
power.c
…
power.h drm/gma500: drop drmP.h from header files 2019-05-22 14:13:33 +02:00
psb_device.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
psb_device.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 335 2019-06-05 17:37:06 +02:00
psb_drv.c drm/gma500: Fix error return code in psb_driver_load() 2021-03-04 11:37:36 +01:00
psb_drv.h drm/gma500: Convert to CRTC VBLANK callbacks 2020-02-13 13:08:13 +01:00
psb_intel_display.c gma500: fix an incorrect NULL check on list iterator 2022-06-09 10:21:28 +02:00
psb_intel_drv.h drm: gma500: Convert to GPIO descriptors 2020-08-19 15:48:09 +02:00
psb_intel_lvds.c drm/gma500: Use simple encoder 2020-04-02 14:16:44 +02:00
psb_intel_modes.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
psb_intel_reg.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 335 2019-06-05 17:37:06 +02:00
psb_intel_sdvo.c drm/gma500: fix spelling mistake "pannel" -> "panel" 2020-08-10 14:15:30 +02:00
psb_intel_sdvo_regs.h
…
psb_irq.c drm/gma500: Fix out-of-bounds access to struct drm_device.vblank[] 2020-11-09 15:09:52 +01:00
psb_irq.h drm/gma500: Convert to CRTC VBLANK callbacks 2020-02-13 13:08:13 +01:00
psb_lid.c Linux 5.2-rc5 2019-06-19 12:07:29 +02:00
psb_reg.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 335 2019-06-05 17:37:06 +02:00
tc35876x-dsi-lvds.c drm/gma500: Use simple encoder 2020-04-02 14:16:44 +02:00
tc35876x-dsi-lvds.h
…