OrangePi_CM5/drivers/net
Eric Dumazet 534762e261 net: tun: call napi_schedule_prep() to ensure we own a napi
commit 07d120aa33cc9d9115753d159f64d20c94458781 upstream.

A recent patch exposed another issue in napi_get_frags()
caught by syzbot [1]

Before feeding packets to GRO, and calling napi_complete()
we must first grab NAPI_STATE_SCHED.

[1]
WARNING: CPU: 0 PID: 3612 at net/core/dev.c:6076 napi_complete_done+0x45b/0x880 net/core/dev.c:6076
Modules linked in:
CPU: 0 PID: 3612 Comm: syz-executor408 Not tainted 6.1.0-rc3-syzkaller-00175-g1118b2049d77 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
RIP: 0010:napi_complete_done+0x45b/0x880 net/core/dev.c:6076
Code: c1 ea 03 0f b6 14 02 4c 89 f0 83 e0 07 83 c0 03 38 d0 7c 08 84 d2 0f 85 24 04 00 00 41 89 5d 1c e9 73 fc ff ff e8 b5 53 22 fa <0f> 0b e9 82 fe ff ff e8 a9 53 22 fa 48 8b 5c 24 08 31 ff 48 89 de
RSP: 0018:ffffc90003c4f920 EFLAGS: 00010293
RAX: 0000000000000000 RBX: 0000000000000030 RCX: 0000000000000000
RDX: ffff8880251c0000 RSI: ffffffff875a58db RDI: 0000000000000007
RBP: 0000000000000001 R08: 0000000000000007 R09: 0000000000000000
R10: 0000000000000001 R11: 0000000000000001 R12: ffff888072d02628
R13: ffff888072d02618 R14: ffff888072d02634 R15: 0000000000000000
FS: 0000555555f13300(0000) GS:ffff8880b9a00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055c44d3892b8 CR3: 00000000172d2000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
napi_complete include/linux/netdevice.h:510 [inline]
tun_get_user+0x206d/0x3a60 drivers/net/tun.c:1980
tun_chr_write_iter+0xdb/0x200 drivers/net/tun.c:2027
call_write_iter include/linux/fs.h:2191 [inline]
do_iter_readv_writev+0x20b/0x3b0 fs/read_write.c:735
do_iter_write+0x182/0x700 fs/read_write.c:861
vfs_writev+0x1aa/0x630 fs/read_write.c:934
do_writev+0x133/0x2f0 fs/read_write.c:977
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f37021a3c19

Fixes: 1118b2049d77 ("net: tun: Fix memory leaks of napi_get_frags")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Wang Yufen <wangyufen@huawei.com>
Link: https://lore.kernel.org/r/20221107180011.188437-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-11-16 09:57:20 +01:00
..
appletalk
…
arcnet
…
bonding net: bonding: Unsync device addresses on ndo_stop 2022-09-28 11:10:31 +02:00
caif caif_virtio: fix race between virtio_device_ready() and ndo_open() 2022-07-07 17:52:18 +02:00
can can: rcar_canfd: rcar_canfd_handle_global_receive(): fix IRQ storm on global FIFO receive 2022-11-03 23:57:54 +09:00
dsa net: dsa: Fix possible memory leaks in dsa_loop_init() 2022-11-10 18:14:16 +01:00
ethernet ethernet: tundra: free irq when alloc ring failed in tsi108_open() 2022-11-16 09:57:14 +01:00
fddi
…
fjes
…
hamradio hamradio: fix issue of dev reference count leakage in bpq_device_event() 2022-11-16 09:57:11 +01:00
hippi drivers: net: hippi: Fix deadlock in rr_close() 2022-05-09 09:05:06 +02:00
hyperv hv_netvsc: Fix race between VF offering and VF association message from host 2022-10-30 09:41:19 +01:00
ieee802154 ieee802154: cc2520: add rc code in cc2520_tx() 2022-09-20 12:38:32 +02:00
ipa net: ipa: properly limit modem routing table use 2022-09-28 11:10:34 +02:00
ipvlan ipvlan: Fix out-of-bound bugs caused by unset skb->mac_header 2022-09-28 11:10:30 +02:00
mdio of: mdio: Add of_node_put() when breaking out of for_each_xx 2022-09-28 11:10:33 +02:00
netdevsim net: Use u64_stats_fetch_begin_irq() for stats fetch. 2022-09-08 11:11:40 +02:00
pcs
…
phy net: phy: mscc: macsec: clear encryption keys when freeing a flow 2022-11-16 09:57:13 +01:00
plip plip: avoid rcu debug splat 2022-08-25 11:37:59 +02:00
ppp
…
slip drivers: net: slip: fix NPD bug in sl_tx_timeout() 2022-04-20 09:23:24 +02:00
team net: team: Unsync device addresses on ndo_stop 2022-09-28 11:10:31 +02:00
usb r8152: add PID for the Lenovo OneLink+ Dock 2022-10-30 09:41:16 +01:00
vmxnet3 net: vmxnet3: fix possible NULL pointer dereference in vmxnet3_rq_cleanup() 2022-05-25 09:17:58 +02:00
wan net: lapbether: fix issue of dev reference count leakage in lapbeth_device_event() 2022-11-16 09:57:10 +01:00
wimax
…
wireguard wireguard: netlink: avoid variable-sized memcpy on sockaddr 2022-09-28 11:10:34 +02:00
wireless wifi: brcmfmac: Fix potential buffer overflow in brcmf_fweh_event_worker() 2022-11-10 18:14:29 +01:00
xen-netback xen-netback: only remove 'hotplug-status' when the vif is actually destroyed 2022-09-15 11:32:05 +02:00
Kconfig lib/crypto: blake2s: include as built-in 2022-05-30 09:33:26 +02:00
LICENSE.SRC
…
Makefile
…
Space.c
…
bareudp.c bareudp: use ipv6_mod_enabled to check if IPv6 enabled 2022-04-08 14:40:22 +02:00
dummy.c
…
eql.c
…
geneve.c geneve: fix TOS inheriting for ipv4 2022-08-25 11:38:02 +02:00
gtp.c
…
ifb.c
…
loopback.c
…
macsec.c macsec: clear encryption keys from the stack after setting up offload 2022-11-16 09:57:09 +01:00
macvlan.c net: macvlan: fix memory leaks of macvlan_common_newlink 2022-11-16 09:57:14 +01:00
macvtap.c macvtap: advertise link netns via netlink 2022-04-13 21:00:59 +02:00
mdio.c
…
mii.c
…
net_failover.c
…
netconsole.c
…
nlmon.c
…
ntb_netdev.c
…
rionet.c
…
sb1000.c
…
sungem_phy.c net: sungem_phy: Add of_node_put() for reference returned by of_get_parent() 2022-08-03 12:00:46 +02:00
tap.c tuntap: add sanity checks about msg_controllen in sendmsg 2022-04-13 21:00:59 +02:00
thunderbolt.c
…
tun.c net: tun: call napi_schedule_prep() to ensure we own a napi 2022-11-16 09:57:20 +01:00
veth.c veth: Ensure eth header is in skb's linear part 2022-04-20 09:23:11 +02:00
virtio_net.c virtio_net: fix memory leak inside XPD_TX with mergeable 2022-08-25 11:37:57 +02:00
vrf.c
…
vsockmon.c
…
vxlan.c vxlan: fix error return code in vxlan_fdb_append 2022-04-27 13:53:53 +02:00
xen-netfront.c xen-netfront: restore __skb_queue_tail() positioning in xennet_get_responses() 2022-07-07 17:52:23 +02:00